RefreshSecurityGroups must be called after unmanaged ENIs are set #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
added a commit
that referenced
this pull request
Jul 24, 2023
) (#2477) * call refresh security groups after unmanaged ENIs are set * update RefreshSGIDs comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#2470
What does this PR do / Why do we need it:
This PR moves the call to
RefreshSGIDstonodeInitafter unmanaged ENIs are set. This is required to fix a regression where security groups on unmanaged ENIs were getting modified during node init.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
This is caused by #2427, which fixed #2426. I manually verified that #2426 is still fixed.
I also manually verified the dependencies on the ordering here. All integration tests pass, and I am kicking off a GitHub runner for this as well.
I filed #2474 to add more integration test coverage for unmanaged ENIs.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.