Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto_removal feature so log lines are NOT dropped from old file #452

Merged
merged 8 commits into from
May 16, 2022
Merged

Fix auto_removal feature so log lines are NOT dropped from old file #452

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4bc6f62
Fix Tail.sendLine() to NOT drop log lines when the tailer is dying be…
adam-mateen Apr 21, 2022
f501db3
Change imported assert package. Use const instead of var.
adam-mateen Apr 22, 2022
d6215e2
Simplify TestLogsFileAutoRemoval().
adam-mateen Apr 22, 2022
89f7561
Remove extra file.Close().
adam-mateen Apr 22, 2022
814331f
Use t.Log() instead of fmt.Println().
adam-mateen Apr 25, 2022
4a84ecf
Use t.Log() instead of fmt.Println() in more places.
adam-mateen Apr 25, 2022
6e9b1c7
Remove unused import.
adam-mateen Apr 25, 2022
02d0661
Fix flaky TestLogsFileAutoRemoval() on high spec hosts.
adam-mateen May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/inputs/logfile/logfile_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,9 @@ func createWriteRead(t *testing.T, prefix string, logFile *LogFile, done chan bo
logSrc, evts := getLogSrc(t, logFile)
defer (*logSrc).Stop()
defer close(evts)
const numLines int = 1000
// Choose a large enough number of lines so that even high-spec hosts will not
// complete receiving logEvents before the 2nd createWriteRead() goroutine begins.
const numLines int = 100000
SaxyPandaBear marked this conversation as resolved.
Show resolved Hide resolved
const msg string = "this is the best log line ever written to a file"
writeLines(t, file, numLines, msg)
file.Close()
Expand Down