Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address naming rules with CronJobControllerV2 for k8s v1.21 #345
Address naming rules with CronJobControllerV2 for k8s v1.21 #345
Changes from 41 commits
a67ac55
74978c2
af5ef66
2df3528
7c911b2
d71a495
6696947
9da9e4f
59ad81d
bb4eed9
79b7a02
36ba09a
8eed962
1e48188
56f4fd4
df6456c
8a0556c
5ae96fa
a29dbe2
c0cca61
3a3dfdf
f3891a5
3445b91
2918c24
cf7f246
f6d5ce1
d2285fd
62f7c14
7368314
dbbeabc
e75dec1
a20b21a
86b9011
ee72ea7
0f1401b
466452d
bce3233
3df097c
b74e23f
f27baa1
4ebd373
e2a7300
90d1a57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, we only need this if the first if-statement evaluates to
false
.