Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom domain cannot be configured for ap-northeast-1 region #605

Closed
6 tasks done
YutakaShimokawa opened this issue Apr 28, 2023 · 4 comments
Closed
6 tasks done
Assignees
Labels

Comments

@YutakaShimokawa
Copy link

YutakaShimokawa commented Apr 28, 2023

Describe the bug
After deploying a stack to the ap-northeast-1 region and configuring a custom domain, sigv4 authentication fails and login becomes impossible.
image

To Reproduce

  1. Deploy in ap-northeast-1 region
  2. Configure custom domain refering to the following manual

https://github.com/aws-solutions/qnabot-on-aws/blob/771b4b465266c19fb863a38c2aa0cd80bf665e96/docs/custom_domain_name_setup/README.md

Expected behavior
Able to login

Please complete the following information about the solution:

  • Version: v5.2.2

  • Region: ap-northeast-1

  • Was the solution modified from the version published on this repository?: No

  • If the answer to the previous question was yes, are the changes available on GitHub?: -

  • Have you checked your service quotas for the sevices this solution uses?: Yes, and no alart

  • Were there any errors in the CloudWatch Logs?: No

@YutakaShimokawa
Copy link
Author

I think it is probably due to the fact that the aws4 library in the following section is set to us-east-1 when the region cannot be determined from the URL path.
https://github.com/aws-solutions/qnabot-on-aws/blob/ecdf9f887bb1cd0688421b57c6809eea6ccd4609/website/js/lib/store/api/actions/index.js

@ihmaws
Copy link
Member

ihmaws commented Jun 23, 2023

Thanks for the report @YutakaShimokawa and sorry for the delay in getting back to you!

The team will have a look and add it into the backlog for investigation.

@jangidms
Copy link
Member

Hi @YutakaShimokawa
Sorry for the delayed response. We are planning a fix for this issue. Please continue to monitor repo for updates

@fhoueto-amz fhoueto-amz mentioned this issue Sep 29, 2023
fhoueto-amz added a commit that referenced this issue Oct 3, 2023
## [5.4.2] - 2023-09-30
### Added
- Self-hosting web fonts. Font files used by QnABot UI are now served from QnABot server instead of using third party font provider.

### Updated

- Security patches for npm and pip packages
- Lambda runtimes updated to NodeJS 18 for CFN Bootstrap Lambda
- SonarQube Quality Gates fix
- Bluebird Promise Migration (Partial)
    - Utilize native promises supported in JavaScript
    - Full migration planned for v5.5.0. Done as a prerequisite for JavaScript SDK v3 migration planned for v6.0.0
    - Remaining changes to be implemented in v5.5.0 include ./website, ./cfn, & ./templates

### Fixed
- Fixed request signing issue when using Custom domain ([issue #605](#605))
- Fixed Sagemaker LLM deployment ([issue #635](#635))
- Fixed voice integration with LLM response
- Fixed unsupported SSML tags
- Fixed Kendra API retrieval bug
@jangidms
Copy link
Member

jangidms commented Oct 4, 2023

Hi @YutakaShimokawa
This issue has been fixed in release 5.4.2

@jangidms jangidms closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants