Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfn-nag false positives #230

Closed
JimTharioAmazon opened this issue Apr 15, 2021 · 0 comments
Closed

cfn-nag false positives #230

JimTharioAmazon opened this issue Apr 15, 2021 · 0 comments
Assignees
Labels
build-and-deploy issues related to building and deploying the project CI/CD finding Issues found with CI/CD workflows
Milestone

Comments

@JimTharioAmazon
Copy link
Member

We can suppress these:

------------------------------------------------------------
./msam-dynamodb-release.template
------------------------------------------------------------------------------------------------------------------------
| WARN W89
|
| Resources: ["DefaultSettingsResource"]
| Line Numbers: [6]
|
| Lambda functions should be deployed inside a VPC
------------------------------------------------------------
| WARN W92
|
| Resources: ["DefaultSettingsResource"]
| Line Numbers: [6]
|
| Lambda functions should define ReservedConcurrentExecutions to reserve simultaneous executions

Failures count: 0
Warnings count: 2
------------------------------------------------------------
./msam-browser-app-release.template
------------------------------------------------------------------------------------------------------------------------
| WARN W89
|
| Resources: ["MSAMWebContentResource", "MSAMWebInvalidationResource"]
| Line Numbers: [234, 292]
|
| Lambda functions should be deployed inside a VPC
------------------------------------------------------------
| WARN W92
|
| Resources: ["MSAMWebContentResource", "MSAMWebInvalidationResource"]
| Line Numbers: [234, 292]
|
| Lambda functions should define ReservedConcurrentExecutions to reserve simultaneous executions

Failures count: 0
Warnings count: 4
------------------------------------------------------------
./aws-media-services-application-mapper-release.template
------------------------------------------------------------
Failures count: 0
Warnings count: 0
------------------------------------------------------------
./msam-events-release.template
------------------------------------------------------------------------------------------------------------------------
| WARN W89
|
| Resources: ["Collector", "AlarmUpdater"]
| Line Numbers: [-1, -1]
|
| Lambda functions should be deployed inside a VPC
------------------------------------------------------------
| WARN W92
|
| Resources: ["Collector", "AlarmUpdater"]
| Line Numbers: [-1, -1]
|
| Lambda functions should define ReservedConcurrentExecutions to reserve simultaneous executions

Failures count: 0
Warnings count: 4
------------------------------------------------------------
./msam-core-release.template
------------------------------------------------------------------------------------------------------------------------
| WARN W89
|
| Resources: ["IncomingCloudwatchAlarm", "UpdateNodes", "UpdateConnections", "UpdateFromTags", "SsmRunCommand", "ProcessSsmRunCommand", "UpdateSsmNodes", "APIHandler"]
| Line Numbers: [-1, -1, -1, -1, -1, -1, -1, -1]
|
| Lambda functions should be deployed inside a VPC
------------------------------------------------------------
| WARN W92
|
| Resources: ["IncomingCloudwatchAlarm", "UpdateNodes", "UpdateConnections", "UpdateFromTags", "SsmRunCommand", "ProcessSsmRunCommand", "UpdateSsmNodes", "APIHandler"]
| Line Numbers: [-1, -1, -1, -1, -1, -1, -1, -1]
|
| Lambda functions should define ReservedConcurrentExecutions to reserve simultaneous executions

Failures count: 0
Warnings count: 16
@JimTharioAmazon JimTharioAmazon added build-and-deploy issues related to building and deploying the project CI/CD finding Issues found with CI/CD workflows labels Apr 15, 2021
@JimTharioAmazon JimTharioAmazon added this to the v1.10.0 milestone Apr 15, 2021
@JimTharioAmazon JimTharioAmazon self-assigned this Dec 6, 2021
@morjoan morjoan assigned morjoan and unassigned JimTharioAmazon Dec 14, 2021
morjoan added a commit that referenced this issue Dec 14, 2021
JimTharioAmazon added a commit that referenced this issue Dec 15, 2021
@morjoan morjoan closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-and-deploy issues related to building and deploying the project CI/CD finding Issues found with CI/CD workflows
Projects
None yet
Development

No branches or pull requests

2 participants