Feature/v4.2.1 #72
Merged
Feature/v4.2.1 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that fixes S3 ownership creation
…n Ohio region. Seeing the error Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting
… causes launch error in Ohio region.
dch90
approved these changes
Apr 17, 2023
sandimciin
approved these changes
Apr 17, 2023
| @@ -2,6 +2,7 @@ | |||
| "app": "npx ts-node bin/live-streaming.ts", | |||
| "context": { | |||
| "aws-cdk:enableDiffNoFail": "true", | |||
| "@aws-cdk/core:stackRelativeExports": "true" | |||
| "@aws-cdk/core:stackRelativeExports": "true", | |||
| "@aws-cdk/aws-s3:serverAccessLogsUseBucketPolicy": true | |||
There was a problem hiding this comment.
are there any logging buckets in this solution that are not for logging cloudfront? Like access logging for s3 buckets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
An upcoming update on AWS S3 restricts that Bucket cannot have ACLs set with ObjectOwnership's
BucketOwnerEnforced setting.
To remediate this issue, the log bucket is updated to include ObjectWriter as part of the OwnershipControls.
Additionally, github workflow changes and security vulnerabilities are fixed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.