Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature to release merge #68

Merged
merged 8 commits into from
Apr 10, 2023
Merged

feature to release merge #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dae030e
Updated the attributeGroupName and the attributeGroupId with new uniq…
eggoynes Apr 4, 2023
8868eac
SonarQube changes needed for code smells publisher review for release…
eggoynes Apr 6, 2023
e5e3c62
Changed nodejs in the buildspec from nodejs 16 to nodejs 18 for update
eggoynes Apr 6, 2023
32698f2
Updating package-lock with dependabot updates
dependabot[bot] Mar 15, 2023
bdfdb56
Bump webpack from 5.72.0 to 5.76.1 in /source/console
dependabot[bot] Mar 15, 2023
657735b
Release date had been changed to Monday to align with techwriter delay
eggoynes Apr 6, 2023
cf3240d
Packages already updated
eggoynes Apr 10, 2023
301c9a1
Build pipeline only supports node 16 node 18 not supported yet.
eggoynes Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [4.2.0] - 2023-4-6
## [4.2.0] - 2023-4-10

### New
- Converted project from CDK 1 to CDK 2 project.
Expand Down
2 changes: 1 addition & 1 deletion buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 0.2
phases:
install:
runtime-versions:
nodejs: 16
nodejs: 16
pre_build:
commands:
- echo "Installing dependencies and executing unit tests - `pwd`"
Expand Down
7 changes: 5 additions & 2 deletions source/constructs/lib/live-streaming.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,9 @@ export class LiveStreaming extends cdk.Stack {
* S3: Logs bucket for CloudFront
*/
const logsBucket = new s3.Bucket(this, 'LogsBucket', {
enforceSSL: true,
versioned: true,
removalPolicy: cdk.RemovalPolicy.RETAIN,
accessControl: s3.BucketAccessControl.LOG_DELIVERY_WRITE,
encryption: s3.BucketEncryption.S3_MANAGED,
blockPublicAccess: {
Expand Down Expand Up @@ -891,8 +894,8 @@ export class LiveStreaming extends cdk.Stack {
const solutionId = 'SO0013';
const solutionName = 'Live Streaming on AWS';
const applicationName = `live-streaming-on-aws-${cdk.Aws.STACK_NAME}`;
const attributeGroup = new appreg.AttributeGroup(this, 'AppRegistryAttributeGroup', {
attributeGroupName: `${cdk.Aws.REGION}-${cdk.Aws.STACK_NAME}`,
const attributeGroup = new appreg.AttributeGroup(this, 'AppRegistryAttributeId', {
attributeGroupName: `A30-${cdk.Aws.REGION}-${cdk.Aws.STACK_NAME}`,
description: "Attribute group for solution information.",
attributes: {
ApplicationType: 'AWS-Solutions',
Expand Down