Fix incorrect case in policy of CustomResourceRole #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct permission in IAM policy should start with capitalized letter after semi-colon. Some policies for CustomResourceRole in this template use lower case letter instead. In my test the corresponding action will be denied.
|
Validate the fix and was able to deploy. @yangaws what's required to get this merged? |
sunnyoui
approved these changes
Mar 15, 2021
|
Hi there, Could any maintainers of this repo have a look at this CR and merge it if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The correct permission in IAM policy should start with capitalized letter after colon. Some policies for CustomResourceRole in this template use lower case letter instead. In my test the corresponding action will be denied.
This PR fixes the case.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.