Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/claude3 sonnet - lambdahook #27

Merged
merged 3 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 30 additions & 18 deletions lambdas/bedrock-embeddings-and-llm/src/lambdahook.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,20 @@ def get_request_body(modelId, parameters, prompt):
provider = modelId.split(".")[0]
request_body = None
if provider == "anthropic":
request_body = {
"prompt": prompt,
"max_tokens_to_sample": DEFAULT_MAX_TOKENS
}
request_body.update(parameters)
# claude-3 models use new messages format
if modelId.startswith("anthropic.claude-3"):
request_body = {
"anthropic_version": "bedrock-2023-05-31",
"messages": [{"role": "user", "content": [{'type':'text','text': prompt}]}],
"max_tokens": DEFAULT_MAX_TOKENS
}
request_body.update(parameters)
else:
request_body = {
"prompt": prompt,
"max_tokens_to_sample": DEFAULT_MAX_TOKENS
}
request_body.update(parameters)
elif provider == "ai21":
request_body = {
"prompt": prompt,
Expand Down Expand Up @@ -59,20 +68,21 @@ def get_request_body(modelId, parameters, prompt):
def get_generate_text(modelId, response):
provider = modelId.split(".")[0]
generated_text = None
response_body = json.loads(response.get("body").read())
print("Response body: ", json.dumps(response_body))
if provider == "anthropic":
response_body = json.loads(response.get("body").read().decode())
generated_text = response_body.get("completion")
# claude-3 models use new messages format
if modelId.startswith("anthropic.claude-3"):
generated_text = response_body.get("content")[0].get("text")
else:
generated_text = response_body.get("completion")
elif provider == "ai21":
response_body = json.loads(response.get("body").read())
generated_text = response_body.get("completions")[0].get("data").get("text")
elif provider == "amazon":
response_body = json.loads(response.get("body").read())
generated_text = response_body.get("results")[0].get("outputText")
elif provider == "cohere":
response_body = json.loads(response.get('body').read())
generated_text = response_body.get("generations")[0].get("text")
elif provider == "meta":
response_body = json.loads(response.get('body').read())
generated_text = response_body.get("generation")
else:
raise Exception("Unsupported provider: ", provider)
Expand All @@ -89,13 +99,15 @@ def replace_template_placeholders(prompt, event):
def format_prompt(modelId, prompt):
provider = modelId.split(".")[0]
if provider == "anthropic":
print("Model provider is Anthropic. Checking prompt format.")
if not prompt.startswith("\n\nHuman:") or not prompt.startswith("\n\nSystem:"):
prompt = "\n\nHuman: " + prompt
print("Prepended '\\n\\nHuman:'")
if not prompt.endswith("\n\nAssistant:"):
prompt = prompt + "\n\nAssistant:"
print("Appended '\\n\\nHuman:'")
# Claude models prior to v3 required 'Human/Assistant' formatting
if not modelId.startswith("anthropic.claude-3"):
print("Model provider is Anthropic v2. Checking prompt format.")
if not prompt.startswith("\n\nHuman:") or not prompt.startswith("\n\nSystem:"):
prompt = "\n\nHuman: " + prompt
print("Prepended '\\n\\nHuman:'")
if not prompt.endswith("\n\nAssistant:"):
prompt = prompt + "\n\nAssistant:"
print("Appended '\\n\\nHuman:'")
print(f"Prompt: {json.dumps(prompt)}")
return prompt

Expand Down
3 changes: 3 additions & 0 deletions lambdas/bedrock-embeddings-and-llm/src/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ def getModelSettings(modelId):
"top_p": 1,
"system": "You are a helpful AI assistant."
}
else:
params.update({"max_tokens_to_sample": 256})
params_qa.update({"max_tokens_to_sample": 256})
lambdahook_args = {"Prefix":"LLM Answer:", "Model_params": params}
settings = {
'LLM_GENERATE_QUERY_MODEL_PARAMS': json.dumps(params),
Expand Down
4 changes: 2 additions & 2 deletions lambdas/bedrock-embeddings-and-llm/template.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AWSTemplateFormatVersion: "2010-09-09"
Description: QnABot on AWS LLM Plugin for Bedrock - v0.1.14
Description: QnABot on AWS LLM Plugin for Bedrock - v0.1.15

Parameters:

Expand Down Expand Up @@ -303,7 +303,7 @@ Resources:
ServiceToken: !GetAtt OutputSettingsFunction.Arn
EmbeddingsModelId: !Ref EmbeddingsModelId
LLMModelId: !Ref LLMModelId
LastUpdate: '03/07/2024 11:45'
LastUpdate: '03/07/2024 12:20'

TestBedrockModelFunction:
Type: AWS::Lambda::Function
Expand Down