Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Randomize SSM parameter name for Grafana token #272

Merged
merged 3 commits into from
May 10, 2024
Merged

fix: Randomize SSM parameter name for Grafana token #272

merged 3 commits into from
May 10, 2024

Conversation

bonclay7
Copy link
Member

@bonclay7 bonclay7 commented May 8, 2024 •
edited
Loading

What does this PR do?

Since we create a hardcoded /terraform-accelerator/grafana-api-key parameter per usage of the eks-monitoring module for storing Grafana API key, this conflicts when using the module multiple times in the same region.

This creates a random suffix for when the key changes.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@bonclay7 bonclay7 requested a review from elamaran11 May 8, 2024 15:47
elamaran11
elamaran11 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment.

examples/existing-cluster-with-base-and-infra/cleanup.sh Show resolved Hide resolved
examples/existing-cluster-with-base-and-infra/install.sh Show resolved Hide resolved
elamaran11
elamaran11 previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonclay7 bonclay7 temporarily deployed to Observability Test May 10, 2024 08:00 — with GitHub Actions Inactive
@bonclay7 bonclay7 merged commit 7100649 into main May 10, 2024
36 checks passed
@bonclay7 bonclay7 deleted the fix/randomize-gh-api-key branch May 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elamaran11 elamaran11 elamaran11 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonclay7 @elamaran11