Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated example for traffic generator #230

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

rafaelpereyra
Copy link
Contributor

@rafaelpereyra rafaelpereyra commented Sep 6, 2023

What does this PR do?

Adds sample NGINX traffic generator deployment to the repository.

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.

Fix #231

Motivation

The current file used for the examples uses a deprecated API, adding the example file in the repository will allow this deployment to succeed.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR
  • [N/A ] Yes, I have added a new example under examples to support my PR (when applicable)
  • Yes, I have updated the Pages for this feature

Note: Not all the PRs required examples and docs.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

❯ kubectl get ingress --namespace nginx-sample-traffic
NAME                 CLASS    HOSTS                                                                   ADDRESS   PORTS   AGE
ingress-nginx-demo   <none>   ****masked****.us-east-1.elb.amazonaws.com             80      25m

@rafaelpereyra rafaelpereyra marked this pull request as ready for review September 6, 2023 23:48
Copy link
Member

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@bonclay7 bonclay7 merged commit a6c0875 into aws-observability:main Sep 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error deploying NGINX traffice generation sample
2 participants