Skip to content

Commit

Permalink
Drop dead variables for kustomization post build
Browse files Browse the repository at this point in the history
  • Loading branch information
bonclay7 committed Aug 17, 2023
1 parent 6ca939d commit 12bef89
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 18 deletions.
8 changes: 1 addition & 7 deletions modules/eks-monitoring/dashboards.tf
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ spec:
name: ${local.apiserver_monitoring_config.flux_gitrepository_name}
postBuild:
substitute:
AMG_AWS_REGION: ${var.managed_prometheus_workspace_region}
AMP_ENDPOINT_URL: ${var.managed_prometheus_workspace_endpoint}
AMG_ENDPOINT_URL: ${var.grafana_url}
GRAFANA_APISERVER_BASIC_DASH_URL: ${local.apiserver_monitoring_config.dashboards.basic}
GRAFANA_APISERVER_ADVANCED_DASH_URL: ${local.apiserver_monitoring_config.dashboards.advanced}
GRAFANA_APISERVER_TROUBLESHOOTING_DASH_URL: ${local.apiserver_monitoring_config.dashboards.troubleshooting}
Expand All @@ -92,10 +89,7 @@ spec:
name: ${local.adothealth_monitoring_config.flux_gitrepository_name}
postBuild:
substitute:
AMG_AWS_REGION: ${var.managed_prometheus_workspace_region}
AMP_ENDPOINT_URL: ${var.managed_prometheus_workspace_endpoint}
AMG_ENDPOINT_URL: ${var.grafana_url}
GRAFANA_ADOTHEALTH_DASH_URL: ${local.adothealth_monitoring_config.dashboards.grafana_adothealth_dashboard_url}
GRAFANA_ADOTHEALTH_DASH_URL: ${local.adothealth_monitoring_config.dashboards.health}
YAML
count = var.enable_adotcollector_metrics ? 1 : 0
depends_on = [module.external_secrets]
Expand Down
1 change: 0 additions & 1 deletion modules/eks-monitoring/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ module "java_monitoring" {
count = var.enable_java ? 1 : 0

pattern_config = coalesce(var.java_config, local.java_pattern_config)

}

module "nginx_monitoring" {
Expand Down
3 changes: 0 additions & 3 deletions modules/eks-monitoring/patterns/istio/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,6 @@ spec:
name: ${var.pattern_config.flux_gitrepository_name}
postBuild:
substitute:
AMG_AWS_REGION: ${var.pattern_config.managed_prometheus_workspace_region}
AMP_ENDPOINT_URL: ${var.pattern_config.managed_prometheus_workspace_endpoint}
AMG_ENDPOINT_URL: ${var.pattern_config.grafana_url}
GRAFANA_ISTIO_CP_DASH_URL: ${var.pattern_config.grafana_istio_cp_dashboard_url}
GRAFANA_ISTIO_MESH_DASH_URL: ${var.pattern_config.grafana_istio_mesh_dashboard_url}
GRAFANA_ISTIO_PERF_DASH_URL: ${var.pattern_config.grafana_istio_performance_dashboard_url}
Expand Down
3 changes: 0 additions & 3 deletions modules/eks-monitoring/patterns/java/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ spec:
name: ${var.pattern_config.flux_gitrepository_name}
postBuild:
substitute:
AMG_AWS_REGION: ${var.pattern_config.managed_prometheus_workspace_region}
AMP_ENDPOINT_URL: ${var.pattern_config.managed_prometheus_workspace_endpoint}
AMG_ENDPOINT_URL: ${var.pattern_config.grafana_url}
GRAFANA_JAVA_JMX_DASH_URL: ${var.pattern_config.grafana_dashboard_url}
YAML
}
4 changes: 0 additions & 4 deletions modules/eks-monitoring/patterns/nginx/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ spec:
name: ${var.pattern_config.flux_gitrepository_name}
postBuild:
substitute:
AMG_AWS_REGION: ${var.pattern_config.managed_prometheus_workspace_region}
AMP_ENDPOINT_URL: ${var.pattern_config.managed_prometheus_workspace_endpoint}
AMG_ENDPOINT_URL: ${var.pattern_config.grafana_url}
GRAFANA_NGINX_DASH_URL: ${var.pattern_config.grafana_dashboard_url}
YAML

}

0 comments on commit 12bef89

Please sign in to comment.