Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting for missing real-time event data #7955

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

svidgen
Copy link
Member

@svidgen svidgen commented Sep 10, 2024

Description of changes:

Adds a troubleshooting accordion under the real-time data (observeQuery) section, explaining why data might appear to be "missing" from real-time updates with tips to resolve.

Related GitHub issue #, if available:

aws-amplify/amplify-js#13267

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@svidgen svidgen requested a review from a team September 10, 2024 14:53
@svidgen svidgen marked this pull request as ready for review September 10, 2024 14:53
@svidgen svidgen requested a review from a team as a code owner September 10, 2024 14:53
Copy link
Member

@stocaaro stocaaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this the right location to inject this content?

Does the accordion allow us to deep link directly to this content?

Overall, I don't have any objections to this, so I'm checking approve. I wonder if there isn't a better way to get this information in front of the customers who are having the problem. I imagine we'll deep link to this from issues / stack overflow articles where folks are encountering this issue, so we want to optimize that experience, if possible.

@svidgen
Copy link
Member Author

svidgen commented Sep 10, 2024

Why is this the right location to inject this content?

Does the accordion allow us to deep link directly to this content?

Overall, I don't have any objections to this, so I'm checking approve. I wonder if there isn't a better way to get this information in front of the customers who are having the problem. I imagine we'll deep link to this from issues / stack overflow articles where folks are encountering this issue, so we want to optimize that experience, if possible.

I'm certainly open to suggestions if something else seems better. My reasoning was that it probably only applies to a subset of customers who are using real-time data, so dropping it as a troubleshooting guidance immediately after that "real-time" data section seemed fitting.

Accordion content doesn't appear link-able unfortunately. But, I had intended to link to the real-time data header and refer to the "associated troubleshooting guide". 🤷

@@ -81,6 +81,102 @@ export default function MyComponent() {

`observeQuery` fetches and paginates through all of your available data in the cloud. While data is syncing from the cloud, snapshots will contain all of the items synced so far and an `isSynced` status of `false`. When the sync process is complete, a snapshot will be emitted with all the records in the local store and an `isSynced` status of `true`.

<Accordion title='Missing real-time events and model fields' headingLevel='4' eyebrow='Troubleshooting'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be heading level 3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tell me! I copied another Accordion and it looked OK to me. I don't see what changing the level actually does. 😅

Copy link
Contributor

@josefaidt josefaidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @svidgen content looks great! left a small comment on the accordions heading level but overall LGTM

@svidgen svidgen merged commit 3092127 into aws-amplify:main Sep 10, 2024
12 checks passed
@svidgen svidgen deleted the ts-missing-realtime-data branch September 10, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants