defineFunction initial implementation
#742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
added
the
run-e2e
🦋 Changeset detectedLatest commit: 3cdb1a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edwardfoyle
requested review from
sobolk,
Amplifiyer and
srquinn21
as code owners
sobolk
reviewed
Nov 29, 2023
packages/backend-function/src/test-assets/default-lambda/handler.ts
Outdated
Show resolved
Hide resolved
...ration-tests/test-projects/data-storage-auth-with-triggers-cjs/amplify/data/echo/handler.cjs
Outdated
Show resolved
Hide resolved
...ntegration-tests/test-projects/data-storage-auth-with-triggers-cjs/update-1/data/resource.ts
Show resolved
Hide resolved
sobolk
previously approved these changes
Nov 29, 2023
Amplifiyer
reviewed
Nov 29, 2023
Comment on lines
+88
to
+99
| // if entry is not set, default to handler.ts | ||
| if (!this.props.entry) { | ||
| return path.join(getCallerDirectory(this.callerStack), 'handler.ts'); | ||
| } | ||
|
|
||
| // if entry is absolute use that | ||
| if (path.isAbsolute(this.props.entry)) { | ||
| return this.props.entry; | ||
| } | ||
| return constructContainer.getOrCompute( | ||
| this.generator | ||
| ) as AmplifyLambdaFunction; | ||
|
|
||
| // if entry is relative, compute with respect to the caller directory | ||
| return path.join(getCallerDirectory(this.callerStack), this.props.entry); |
There was a problem hiding this comment.
do we have req for these fallbacks?
There was a problem hiding this comment.
Does req mean requirements? I'm not sure the PMs have explicitly stated it anywhere, but they have written examples where they seem to expect this behavior.
Amplifiyer
previously approved these changes
Nov 29, 2023
sobolk
previously approved these changes
Nov 29, 2023
sobolk
approved these changes
Nov 29, 2023
alharris-at
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Initial implementation of
defineFunction. This PR includes:function-construct-alphapackagebackend-functionto removeFunc.fromDirandFunc.buildin favor ofdefineFunctionwhich acts as a wrapper around CDK's NodejsFunctionWhat's not included:
defineFunctionis not implemented. Things like lambda memory size, timeout, and environment variables are easy additions in follow up PRsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.