fix: Force colors to not be stripped off when piping child process stdout #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb7f2bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
reviewed
Nov 16, 2023
Comment on lines
173
to
176
| // Piping the output by default strips off the color. This is a workaround to | ||
| // preserve the color being piped to parent process. Later we reset it to whatever it was before. | ||
| const oldForceColorValue = process.env['FORCE_COLOR']; | ||
| process.env['FORCE_COLOR'] = '1'; |
There was a problem hiding this comment.
Can we clone process.env, append this to a copy and pass to child process ?
There was a problem hiding this comment.
Good idea, only setting in the child process now.
| @@ -184,6 +189,7 @@ export class CDKDeployer implements BackendDeployer { | |||
|
|
|||
| try { | |||
| await childProcess; | |||
| process.env['FORCE_COLOR'] = oldForceColorValue; | |||
There was a problem hiding this comment.
this should be in finally block.
There was a problem hiding this comment.
no longer needed.
edwardfoyle
approved these changes
Nov 16, 2023
sobolk
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Piping the child process output by default strips off the color for consuming streams. This is a workaround to preserve the color being piped to parent process. See Marak/colors.js#127 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.