Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lorca #2510

Closed
wants to merge 2 commits into from
Closed

Add Lorca #2510

wants to merge 2 commits into from

Conversation

melignus
Copy link

@melignus melignus commented May 6, 2019

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added godoc link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Copy link
Collaborator

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is ok, but where's the coverage?

@melignus
Copy link
Author

melignus commented May 7, 2019

Build is ok, but where's the coverage?

I apologize. I was following this example #2507 which uses the passing travis build in place of the coverage link. I will reach out to the lorca maintainer to see if they have a solution.

@melignus melignus closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants