Detect t.try() usage in hooks; experimentally disable t.snapshot() #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novemberborn
requested changes
Jun 28, 2020
oantoro
force-pushed
the
disable-snapshot-and-try-in-hooks
branch
from
65b9ad1
to
63568bf
Compare
tymfear
reviewed
Jun 30, 2020
|
@novemberborn when something is released under the feature flag, when it is a good time to update docs? |
And make it fail the test.
* Rename directory * Snapshot the error message
novemberborn
reviewed
Jul 4, 2020
There was a problem hiding this comment.
@okyantoro thanks, I've made a few more tweaks. Let me know what you think.
@tymfear neither of those files mention using snapshots or try() in hooks, so I don't think we need to explicitly point this out. You'll realize when you try to use it.
novemberborn
approved these changes
Jul 4, 2020
|
Thank you @novemberborn |
novemberborn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will disable snapshots and try assertions in hooks. But I am not sure with the unit test. Let me know if additional work is required.
Fixes #2523