Removed Metrics from the Event Loop #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momosh-ethernal
requested review from
vbhattaccmu,
sh3ll3x3c and
aterentic-ethernal
vbhattaccmu
approved these changes
Aug 23, 2024
client/src/main.rs
Outdated
| @@ -98,7 +98,13 @@ async fn run( | |||
| ) | |||
| .await?; | |||
|
|
|||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run(ot_metrics.clone()))); | |||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run())); | |||
There was a problem hiding this comment.
We should run event loop after the call to resubscribe to avoid skipping an event.
client/src/main.rs
Outdated
| let metrics_clone = ot_metrics.clone(); | ||
| tokio::spawn(async move { | ||
| let stream = BroadcastStream::new(event_receiver.resubscribe()); | ||
| metrics_clone.handle_event_stream(stream).await |
There was a problem hiding this comment.
Can we create stream in the handle_event_stream so we can reduce code in the main fn to:
tokio::spawn(metrics_clone.handle_event_stream(event_receiver.resubscribe()))
crawler/src/main.rs
Outdated
| @@ -100,7 +101,13 @@ async fn run(config: Config, db: DB, shutdown: Controller<String>) -> Result<()> | |||
| ) | |||
| .await?; | |||
|
|
|||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run(ot_metrics.clone()))); | |||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run())); | |||
There was a problem hiding this comment.
Same thing for this run, lets move it after resubscribe.
fat/src/main.rs
Outdated
| @@ -100,7 +101,13 @@ async fn run(config: Config, db: DB, shutdown: Controller<String>) -> Result<()> | |||
| ) | |||
| .await?; | |||
|
|
|||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run(ot_metrics.clone()))); | |||
| spawn_in_span(shutdown.with_cancel(p2p_event_loop.run())); | |||
There was a problem hiding this comment.
Same thing for this run, lets move it after resubscribe.
sh3ll3x3c
approved these changes
Aug 26, 2024
sh3ll3x3c
approved these changes
Aug 26, 2024
sh3ll3x3c
approved these changes
Aug 26, 2024
aterentic-ethernal
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.