Signature handler refactor #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
requested review from
ceyonur,
darioush and
patrick-ogrady
as code owners
| ) | ||
|
|
||
| var ( | ||
| _ SignatureRequestHandlerStats = (*handlerStats)(nil) |
There was a problem hiding this comment.
Trying to figure out difference between (*handlerStats)(nil) and &handlerStats{}, is it the difference between nil and a default struct value?
Should we always use (*struct)(nil) i'm thinking for MockHandlerStats etc
There was a problem hiding this comment.
They're both used to ensure that the struct implements the interface.
I've switched to using (*type)(nil). It doesn't make much of a difference and tbh we should be consistent, but currently use both in different places.
Here's one article: https://splice.com/blog/golang-verify-type-implements-interface-compile-time/.
minghinmatthewlam
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR re-organizes the stats and handlers and reduces the duplicated stats code.
How this works
This PR uses the embedded stats and handlers rather than duplicating function calls to do many passthroughs to the underlying stats.
How this was tested
This PR is tested in CI
How is this documented
no documentation necessary for this change