Precompile improvements merge (#513)

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Co-authored-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
Co-authored-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
Co-authored-by: Matthew Lam <matthew.lam@avalabs.org>
Co-authored-by: cam-schultz <camschultz32@gmail.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: Anusha <63559942+anusha-ctrl@users.noreply.github.com>
Co-authored-by: Hagen Hübel <hhuebel@itinance.com>
Co-authored-by: minghinmatthewlam <matthew.lam@avalabs.org>
Fix: typos (#428)
fix allow list comments (#469)
fix CGO flags issue (#489)
fix lint job (#499)

.github/CODEOWNERS

@@ -6,12 +6,10 @@
 
 # review whenever someone opens a pull request.
 
-* @ceyonur @darioush @patrick-ogrady @aaronbuchwald
+* @ceyonur @darioush @aaronbuchwald
 
-# These owners will be the owner of the contract-examples sub-directory.
-
-contract-examples/ @dasconnor @anusha-ctrl
-
-# These owners will be the owner of the scripts sub-directory.
+# Specific directories:
 
+peer/ @anusha-ctrl
+contract-examples/ @anusha-ctrl
 scripts/ @anusha-ctrl

.github/CONTRIBUTING.md

@@ -1,35 +1,45 @@
 # Contributing
 
-Thank you for considering to help out with the source code! We welcome 
-contributions from anyone on the internet, and are grateful for even the 
+Thank you for considering to help out with the source code! We welcome
+contributions from anyone on the internet, and are grateful for even the
 smallest of fixes!
 
-If you'd like to contribute to coreth, please fork, fix, commit and send a 
+If you'd like to contribute to subnet-evm, please fork, fix, commit and send a
 pull request for the maintainers to review and merge into the main code base. If
-you wish to submit more complex changes though, please check up with the core 
-devs first on [Discord](https://chat.avalabs.org) to 
-ensure those changes are in line with the general philosophy of the project 
+you wish to submit more complex changes though, please check up with the core
+devs first on [Discord](https://chat.avalabs.org) to
+ensure those changes are in line with the general philosophy of the project
 and/or get some early feedback which can make both your efforts much lighter as
 well as our review and merge procedures quick and simple.
 
 ## Coding guidelines
 
-Please make sure your contributions adhere to our coding guidelines:
-
- * Code must adhere to the official Go 
-[formatting](https://golang.org/doc/effective_go.html#formatting) guidelines 
-(i.e. uses [gofmt](https://golang.org/cmd/gofmt/)).
- * Code must be documented adhering to the official Go 
-[commentary](https://golang.org/doc/effective_go.html#commentary) guidelines.
- * Pull requests need to be based on and opened against the `master` branch.
- * Pull reuqests should include a detailed description
- * Commits are required to be signed. See [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
- for information on signing commits.
- * Commit messages should be prefixed with the package(s) they modify.
-   * E.g. "eth, rpc: make trace configs optional"
+Please make sure your contributions adhere to our coding and documentation
+guidelines:
+
+- Code must adhere to the official Go
+  [formatting](https://golang.org/doc/effective_go.html#formatting) guidelines
+  (i.e. uses [gofmt](https://golang.org/cmd/gofmt/)).
+- Pull requests need to be based on and opened against the `master` branch.
+- Pull reuqests should include a detailed description
+- Commits are required to be signed. See [here](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
+  for information on signing commits.
+- Commit messages should be prefixed with the package(s) they modify.
+  - E.g. "eth, rpc: make trace configs optional"
+
+## Documentation guidelines
+
+- Code should be well commented, so it is easier to read and maintain.
+ Any complex sections or invariants should be documented explicitly.
+- Code must be documented adhering to the official Go
+  [commentary](https://golang.org/doc/effective_go.html#commentary) guidelines.
+- Changes with user facing impact (e.g., addition or modification of flags and
+ options) should be accompanied by a link to a pull request to the [avalanche-docs](https://github.com/ava-labs/avalanche-docs)
+ repository. [example](https://github.com/ava-labs/avalanche-docs/pull/1119/files). 
+- Changes that modify a package significantly or add new features should
+ either update the existing or include a new `README.md` file in that package.
 
 ## Can I have feature X
 
-Before you submit a feature request, please check and make sure that it isn't 
+Before you submit a feature request, please check and make sure that it isn't
 possible through some other means.
-

.github/ISSUE_TEMPLATE/release_checklist.md

@@ -0,0 +1,25 @@
+---
+name: Release Checklist
+about: Create a ticket to track a release
+title: ''
+labels: release
+assignees: ''
+
+---
+
+**Release**
+The release version and a description of the planned changes to be included in the release.
+
+**Issues**
+Link the major issues planned to be included in the release.
+
+**Documentation**
+Link the relevant documentation PRs for this release.
+
+**Checklist**
+- [ ] Update version in scripts/versions.sh and plugin/evm/version.go
+- [ ] Bump AvalancheGo dependency for RPCChainVM Compatibility
+- [ ] Add new entry in compatibility.json for RPCChainVM Compatibility
+- [ ] Update AvalancheGo compatibility in README
+- [ ] Bump cmd/simulator go mod (if needed)
+- [ ] Confirm goreleaser job has successfully generated binaries by checking the releases page

.github/pull_request_template.md

@@ -3,3 +3,5 @@
 ## How this works
 
 ## How this was tested
+
+## How is this documented

.github/workflows/lint-tests-release.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   lint_test:
     name: Lint
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v3
       - run: ./scripts/lint_allowed_geth_imports.sh
@@ -63,29 +63,15 @@ jobs:
       - name: Yarn install
         run: yarn
         working-directory: ./contract-examples
-      - name: Run e2e tests
+      - name: Install AvalancheGo Release
         shell: bash
-        run: SKIP_NETWORK_RUNNER_START=true SKIP_NETWORK_RUNNER_SHUTDOWN=true ENABLE_SOLIDITY_TESTS=true scripts/run.sh
-
-  simulator_test:
-    name: Load testing with simulator
-    runs-on: ubuntu-latest
-    steps:
-      - name: Git checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-      - name: Set up Go
-        uses: actions/setup-go@v3
-        with:
-          go-version: 1.18
-      - name: Install dependencies with go module
+        run: BASEDIR=/tmp/e2e-test AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego ./scripts/install_avalanchego_release.sh
+      - name: Build Subnet-EVM Plugin Binary
         shell: bash
-        run: go mod download
-      - name: Run simulator tests
+        run: ./scripts/build.sh /tmp/e2e-test/avalanchego/plugins/srEXiWaHuhNyGwPUi444Tu47ZEDwxTWrbQiuD7FmgSAQ6X7Dy
+      - name: Run E2E Tests
         shell: bash
-        # skip shutdown so external simulator binary can run against the existing cluster
-        run: SKIP_NETWORK_RUNNER_SHUTDOWN=true RUN_SIMULATOR=true scripts/run.sh
+        run: AVALANCHEGO_BUILD_PATH=/tmp/e2e-test/avalanchego DATA_DIR=/tmp/e2e-test/data ./scripts/run_ginkgo.sh
 
   release:
     # needs: [lint_test, unit_test, e2e_test, simulator_test]