feat: add autoware_map_msgs for dynamic map loading #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
7 tasks
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…github.com:kminoda/autoware_msgs into feat/add_autoware_map_msgs_for_dynamic_map_loading
kminoda
requested review from
YamatoAndo,
mitsudome-r,
yukkysaito and
xmfcx
yukkysaito
reviewed
Sep 28, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
yukkysaito
reviewed
Sep 28, 2022
yukkysaito
reviewed
Sep 28, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
yukkysaito
reviewed
Sep 28, 2022
yukkysaito
reviewed
Sep 28, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
force-pushed
the
feat/add_autoware_map_msgs_for_dynamic_map_loading
branch
from
a43f673
to
3b76daf
Compare
Signed-off-by: kminoda <koji.minoda@tier4.jp>
xmfcx
requested changes
Oct 17, 2022
Signed-off-by: kminoda <koji.minoda@tier4.jp>
7 tasks
|
@mitsudome-r @yukkysaito Would you review or approve this PR? |
xmfcx
approved these changes
Oct 26, 2022
4 tasks
|
@kenji-miyake Sorry, would you make this DCO pass again? |
|
@mitsudome-r @kenji-miyake (mentioning whom seem to have the write access) (Of course any comments instead of the merge is also welcome) |
|
@kminoda I think @mitsudome-r or @xmfcx is the right person to merge this. |
|
I've merged it, @mitsudome-r if you have any comments, we can resolve them in another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.m.minoda@gmail.com
Description
Add autoware_map_msgs to integrate a new interface for dynamic map loading. See https://github.com/orgs/autowarefoundation/discussions/2812 for detail.
Related links
The next step of this PR would be to create a dynamic map loading functionality in
map_loader. Here's how it's going to look like: autowarefoundation/autoware.universe#1938Tests performed
Notes for reviewers
modein the response field ofsrv/LoadPCDMaps?Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.