Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ansible): refactor PR #5053 #5104

Merged
merged 29 commits into from
Sep 10, 2024
Merged

feat(ansible): refactor PR #5053 #5104

merged 29 commits into from
Sep 10, 2024

Conversation

shtokuda
Copy link
Contributor

@shtokuda shtokuda commented Aug 19, 2024 •
edited
Loading

Description

#5053

We can set up influxDB + Telegraf by following command:
./setup-dev-env.sh telegraf

Related links

Tests performed

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

youtalk and others added 24 commits July 30, 2024 16:34
@youtalk
add telegraf scripts
d1d7269 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
rename
28b63f3 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
add conf
47be631 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
mv
648a277 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
add files
593d1d2 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
add copy
8e34307 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
add playbook
f7ab3b8 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
add handlers
7632e99 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
install influxdb2
c7d1690 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@pre-commit-ci
style(pre-commit): autofix
7552031
@youtalk
add readme
af58f7c 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk
update readme
f9073fb
@pre-commit-ci
style(pre-commit): autofix
2519782
@youtalk
add net and nvidia_smi
286d390 
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@shtokuda
update telegraf tasks
bf956ac 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
modify for precommit ansible
2c4eb13 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
modify to use FQCN
bb693d2 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
modify ansoble command condition
36ff500 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
modify other part for precommit ansible
ba6130a 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
add service influxDB
ceafa31 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
add telegraf binary directory
76ba90f 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
add become true for running service
b713438 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
fixed by yamlint
85c3a3d 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda
add ansible chmod and changed_when
a382d70 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
@shtokuda shtokuda marked this pull request as ready for review September 9, 2024 01:11
youtalk
youtalk reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

ansible/roles/telegraf/files/telegraf.conf Outdated Show resolved Hide resolved
@shtokuda @youtalk
fix(telegraf.conf): Update explanation of access tokens
543df11 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>

Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk added the tag:run-health-check Run health-check label Sep 9, 2024
youtalk
youtalk approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk enabled auto-merge (squash) September 9, 2024 06:25
@youtalk
Copy link
Member

youtalk commented Sep 9, 2024

Please check the pre-commit.ci - pr error. https://results.pre-commit.ci/run/github/41331761/1725851643.gTuOOOjpTPKPQ3PeonO-GA

shtokuda and others added 2 commits September 9, 2024 19:44
@shtokuda
Merge branch 'main' into telegraf
25a4aaf
@shtokuda
fix for pre-commit.ci
a1360f5 
Signed-off-by: shtokuda <shumpei.tokuda@tier4.jp>
auto-merge was automatically disabled September 9, 2024 10:56

Head branch was pushed to by a user without write access

@youtalk youtalk enabled auto-merge (squash) September 10, 2024 02:49
@youtalk youtalk merged commit dc6a0dc into autowarefoundation:main Sep 10, 2024
13 of 15 checks passed
@shtokuda shtokuda deleted the telegraf branch September 10, 2024 04:23
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youtalk youtalk youtalk approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

Assignees
No one assigned
Labels
tag:run-health-check Run health-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shtokuda @youtalk