fix: update all downloaded files with their SHA256 checksum (2) #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
esteve
force-pushed
the
update-ansible-sha256
branch
from
72d8dc3
to
325360a
Compare
|
@lexavtanke could you review this PR again? I closed #3856 by mistake. Thanks. |
38 tasks
lexavtanke
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
@esteve LGTM but I guess you will also need approval from someone else with write permit because I still don't have any merged PRs to autoware repo.
|
@xmfcx could you approve this PR? Neither @lexavtanke or I have write permissions for this repository. Thanks. |
xmfcx
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use SHA256 checksums for all the downloaded files.
#3856 was closed by mistake when I deleted my fork.
See autowarefoundation/autoware.universe#3137
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.