Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix localization's input pointcloud #491

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Nov 30, 2023

Description

There are cases where a point cloud integrating multiple LiDARs is used as input to localization, and there are also cases where a single LiDAR is used.
Therefore, I have modified the design/autoware-interface/componets/sensing.md.

Additionally, I have corrected the topic name of the input point cloud in the node diagram for localization to match the current state ( /sensing/lidar/pointcloud -> /sensing/lidar/top/pointcloud ).

Related PRs

Merge all Related PRs at the same time.

#491
autowarefoundation/autoware.universe#5781
autowarefoundation/sample_sensor_kit_launch#82
autowarefoundation/autoware_launch#722
RobotecAI/awsim_sensor_kit_launch#12
autowarefoundation/awf_reference_sensor_kit_launch#7

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

yamato-ando added 2 commits November 30, 2023 18:29
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
@mitsudome-r mitsudome-r added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Nov 30, 2023
@YamatoAndo YamatoAndo marked this pull request as draft December 1, 2023 06:28
yamato-ando and others added 8 commits December 5, 2023 16:15
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Signed-off-by: yamato-ando <Yamato ANDO>
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's almost good, but it is better to write "T.B.D." for the empty topic names.

yamato-ando and others added 2 commits December 6, 2023 14:41
Signed-off-by: yamato-ando <Yamato ANDO>
@YamatoAndo
Copy link
Contributor Author

@isamu-takagi Thank you for the comment. I have modified it.

@YamatoAndo YamatoAndo merged commit c9b3193 into autowarefoundation:main Dec 8, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants