[hotfix] Use correct files list for sorting annotations when viewing an archive

[damianhxy]

Description

Use result from Archive.get_files, rather than @files, when calling get_correct_filename in view.

Hotfix for #1590

Motivation and Context

Currently, we are using @files when finding the filenames for annotations.

The problem with this is that @files is the result of Archive.get_file_hierarchy, whose length does not correspond directly to the number of files (subfiles are recursively nested). Rather its length is the number of "top level" files / directories.

This further results in an error when get_correct_filename calls Archive.get_nth_filename, potentially on an out of bounds index.

However, viewFeedback handles this correctly since @files is only set for Archives, and is set to the result of Archive.get_files.

How Has This Been Tested?

• Create an assessment that accepts tar files
• Upload hello.tar.zip (unzip this first)
• Create a problem and annotate a nested file

Before

After

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have run rubocop for style check. If you haven't, run overcommit --install && overcommit --sign to use pre-commit hook for linting

[20wildmanj]

• LGTM, Verified that the fix works, can now view an Archive with annotated files
• Should mention this is a hotfix for Fix order of annotations on feedback view and file view to be consistent #1590