Fix creation of missing submissions #1584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nil
.Motivation and Context
As reported in
INC1029200
, an internal server error occurs when one attempts to fill in blank submissions for missing submissions.This is because the autocomplete js code attempts to run even when CUD is set (so there's no need to autocomplete anything). However, the required data is not initialized in such a case, so we attempt to iterate over
nil
.Fill in Empty Submissions feature
Server only initializes autocomplete data when CUD is not nil
To remedy this, don't run autocomplete js code unless there is a need to.
How Has This Been Tested?
Before changes
After changes
Types of changes
Checklist:
overcommit --install && overcommit --sign
to use pre-commit hook for linting