-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hessian and Jacobian #117
Hessian and Jacobian #117
Conversation
Since fwd_adj is theoretically the fastest higher order mode for computing Hessians, I'm unsure if I should implement overloads for other modes or enforce fwd_adj with Hessian. |
Edited: I think |
Pull Request Test Coverage Report for Build 9400516425Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we would like to eventually move the implementations of Hessian and Jacobian into source files, explicitly instantiating them for the possible types T
where it makes sense. This gives us a chance to potentially optimise / parallelise the code in future directly with XAD compilation and keep the user code compatible.
You will also need to add some reference doc for these, but it's ok to do this at the end.
Also feel free to merge or rebase |
Pull Request Test Coverage Report for Build 9402307189Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9416215933Details
💛 - Coveralls |
Please disregard this for now. The templated iterator approach will not allow to move this to a source file. We can worry at this later if it's needed. |
Microsoft has made a jump in the toolset version recently - latest Visual Studio 2022 is now toolset 14.4. That makes the Windows builds fail. I'd say we make the toolsets tested 14.0, 14.1, 14.2, 14.4 now. |
Pull Request Test Coverage Report for Build 9416864531Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9437069353Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9449458656Details
💛 - Coveralls |
Also a note regarding the documentation you added. The files under docs/ref go verbatim onto the documentation reference section on the website. They need to be written in the style of a reference manual - showing the functions provided, listing/explaining their parameters, along with a short description what the function or header does. Similar to the other files there. I believe headers.md will also need to be adapted for the 2 new headers that aren't included by default. We will have to extend the docs in this part of the website (not part of this repository), and we will take part of what you have written so far for that with the next release. |
- Added sample programs for Hessian and Jacobian - Added doc for Hessian and Jacobian - Tweaked TypeTraits tests to be easier to understand - Changed order of some checks for iterators Upcoming: - More efficient fwd Jacobian computation - Possibly less evaluations of foo for Jacobian
Pull Request Test Coverage Report for Build 9466495859Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9467581491Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9467629163Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9468181393Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9468434477Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9472794925Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9472947691Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nearly there now - many of our comments are small consistency corrections / doc changes, that you should be able to just accept. Otherwise a few small changes are still needed.
Pull Request Test Coverage Report for Build 9480444406Details
💛 - Coveralls |
26d2385
into
auto-differentiation:main
Description
Implementation of Hessian and Jacobian class methods as per #37.
Features:
Unrelated changes: