Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleClang15 patch #116

Commits on May 19, 2024

  1. Added NEON SIMD option.

    raneamri committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2e342af View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Fixed libc++ related issues & small CMake fix\n\n- __builtin_isinf no…

    … longer used on arm architectures\n- NEON SIMD option only auto selected on arm architectures, defaults to AVX otherwise\n- polar() function now defaults arg2 to 0.0 rather than throwing an error/ignoring overload\n- <StdCompatibility.cpp> auto included for arm & appleclang15\n - One test changed in Complex_test.cpp to prevent overload error. This is a temporary change and the test will be restored once the error related to std::norm is fixed\n - Added Mac Clang15 workflow (debug & release) to ci.yml (yet to test)
    raneamri committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ff4f8e1 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. std::norm overload selection fixed.

    - Proper overload for std::norm now selected when norm is called with type param.
    - Added NEON SIMD option to drop down menu for CMake GUI
    - Restored test I previously changed
    raneamri committed May 24, 2024
    Configuration menu
    Copy the full SHA
    660f870 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. CI & CMake changes + fixed overload settlement for std::norm

    - M1 workflow no longer needlessly installs llvm15
    - Fixed erroneous formatting error & redundant flag addition
    - SIMD: NEON -> APPLE_M1, & added NATIVE
    - norm overloads now use = Constructor() rather than = 0 where relevant
    - Removed redundant include of <StdCompatibility.hpp> in XAD.hpp
    - Windows 14.1 build now uses 2019 runner
    raneamri committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7341a93 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Overload tweak for Complex.hpp & SIMD changes

    - Changed APPLE_M1 flag -march=apple-m1 -> -march=armv8.5-a
    - Removed redundant GNU branch in SetupCompiler.cmake
    - Added better system resolve (Darwin/Linux) in SetupOptions.cmake
    - Changed overload for norm as to enable if type is XAD rather than disable if type is a c++ native type
    
    This fix intends to fix the flag issue for the macoslatest workflow. It may not; in which case this task is relayed it to the next commit.
    Next fix will fix baseline coverage issues for Mac (Debug)
    raneamri committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f90788c View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Changed test to use tolerance value & CI changes:

    - Merged macos-13 & macos-latest into wider matrix build.
    - Changed Mac (Debug) to use lcov@1.14 rather than lcov@2.1 to try fix coverage baseline issue.
    - Changed Expressions_test 1686 to use tolerance value rather than DOUBLE_EQ.
    
    The lcov version downgrade may not fix coverage baseline, in which case that change will be reverted
    raneamri committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7d20eb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a9bbefb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90c0380 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8658ef9 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    f1f86f4 View commit details
    Browse the repository at this point in the history