Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3106] Fix up tests for Ruby 3 and rspec-mocks update #313

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 11, 2022

Changes

Tests were starting to fail after upgrading rspec-mocks on Ruby 3.0, thanks to this change in Ruby 3. This PR updates the tests so that they now run and pass.

No actual test logic has changed, and the change across all the files is exactly the same type of change (adding braces around positional arguments that should be treated as a hash).

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner February 11, 2022 12:36
@stevehobbsdev stevehobbsdev added the review:small Small review label Feb 11, 2022
@stevehobbsdev stevehobbsdev merged commit 1b5c02a into master Feb 11, 2022
@stevehobbsdev stevehobbsdev deleted the chore/fix-tests branch February 11, 2022 16:10
This was referenced Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants