Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint pagination [SDK-2667] #284

Merged
merged 10 commits into from
Jul 23, 2021
Merged

Checkpoint pagination [SDK-2667] #284

merged 10 commits into from
Jul 23, 2021

Conversation

davidpatrick
Copy link
Contributor

Changes

This PR includes method documentation (docblock) updates to reflect the availability of checkpoint pagination parameters on supported endpoints. It does not add any new functionality or require new tests.

References

Please see the internal Jira tickets SDK-2667 and related epic SDK-2653 for details on this initiative.

@davidpatrick davidpatrick requested a review from a team as a code owner July 20, 2021 22:57
jimmyjames
jimmyjames requested changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few doc block suggestions.

lib/auth0/api/v2/logs.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/logs.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/organizations.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/organizations.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/organizations.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/organizations.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/roles.rb Outdated Show resolved Hide resolved
lib/auth0/api/v2/roles.rb Outdated Show resolved Hide resolved
davidpatrick and others added 8 commits July 23, 2021 12:11
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/logs.rb
b44827a 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/logs.rb
d9f5367 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/organizations.rb
079927e 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/organizations.rb
71b569a 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/organizations.rb
799bb70 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/organizations.rb
906dbc5 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/roles.rb
9d51f22 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick @jimmyjames
Update lib/auth0/api/v2/roles.rb
54a9dce 
Co-authored-by: Jim Anderson <jim.anderson@auth0.com>
@davidpatrick davidpatrick merged commit df21d7b into master Jul 23, 2021
@davidpatrick davidpatrick added this to the vnext milestone Jul 23, 2021
@davidpatrick davidpatrick changed the title Document checkpoint pagination params [SDK-2667] Checkpoint pagination [SDK-2667] Jul 23, 2021
@davidpatrick davidpatrick modified the milestones: v5.2.0, 5.3.0 Jul 23, 2021
@davidpatrick davidpatrick mentioned this pull request Jul 23, 2021
Merged
@stevehobbsdev stevehobbsdev deleted the checkpoint_paging branch September 29, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpatrick @jimmyjames