Keep the ID Token storing default in v2 #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Widcket
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
I've decided to keep the default of storing the ID Token in the session because it may be required in RP initiated logout (we will likely require the
id_token_hintto prevent the logout prompt by default)📎 References
https://openid.net/specs/openid-connect-rpinitiated-1_0.html#:~:text=At%20the%20Logout%20Endpoint%2C%20the%20OP%20SHOULD%20ask%20the%20End%2DUser%20whether%20to%20log%20out%20of%20the%20OP%20as%20well.%20Furthermore%2C%20the%20OP%20MUST%20ask%20the%20End%2DUser%20this%20question%20if%20an%20id_token_hint%20was%20not%20provided