[SDK-3570] Upgrade to Jose@4 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
# Conflicts: # src/handlers/profile.ts # tests/session/update-user.test.ts
panva
reviewed
Aug 31, 2022
panva
reviewed
Sep 1, 2022
panva
reviewed
Sep 1, 2022
# Conflicts: # src/auth0-session/transient-store.ts # src/config.ts
panva
approved these changes
Sep 6, 2022
Widcket
reviewed
Sep 6, 2022
| if (!session || !user) { | ||
| return; | ||
| } | ||
| sessionCache.set(req, res, { ...session, user }); | ||
| await sessionCache.set(req, res, { ...session, user }); |
There was a problem hiding this comment.
Is this last await necessary, or could it be just return sessionCache.set(req, res, { ...session, user });?
There was a problem hiding this comment.
You could do either. It only really makes a difference when you're using try/catch statements
try {
return promise;
} catch () {};
// is very different from
try {
return await promise;
} catch () {};Also, returning from updateUser would change the function return type from Promise<void> to Promise, whilst being practically equivalent - I think for a function that shouldn't return anything Promise` is probably more suitable
Widcket
reviewed
Sep 6, 2022
| this.cache.set(req, session); | ||
| this.save(req, res); | ||
| await this.save(req, res); |
There was a problem hiding this comment.
Is this last await necessary, or could it be just return this.save(req, res);?
Widcket
reviewed
Sep 6, 2022
| this.cache.set(req, null); | ||
| this.save(req, res); | ||
| await this.save(req, res); |
Widcket
reviewed
Sep 6, 2022
| this.cache.set(req, session); | ||
| this.save(req, res); | ||
| await this.save(req, res); |
Widcket
reviewed
Sep 6, 2022
| save(req: NextApiOrPageRequest, res: NextApiOrPageResponse): void { | ||
| this.cookieStore.save(req, res, this.cache.get(req), this.iatCache.get(req)); | ||
| async save(req: NextApiOrPageRequest, res: NextApiOrPageResponse): Promise<void> { | ||
| await this.cookieStore.save(req, res, this.cache.get(req), this.iatCache.get(req)); |
Widcket
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Have upgraded jose from 2 -> 4 - this is a requirement for running the SDK on Vercel Edge Middleware (and other edge runtimes). cookie read/save is now async so there are a bunch of changes to make accessing/updating the session async.
Main changes are:
Then adding a bunch of
async/awaits📎 References
https://github.com/panva/jose/releases/tag/v3.0.0
https://github.com/panva/jose/releases/tag/v4.0.0