Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain when clearing cookie #79

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

bunea
Copy link
Contributor

@bunea bunea commented Feb 7, 2020

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

I ran into a problem when setting the cookieDomain option in the session config. The cookie is set correctly when logging in, but because the domain is missing when clearing the cookie in the logout handler it seems that the cookie is not cleared and I remain logged in. Although if I try logging in again Auth0 presents me with the login page.

It looks like an easy fix to add the cookieDomain when clearing the cookie, but I'm not sure if this is the right approach.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@sandrinodimattia sandrinodimattia merged commit 215ff62 into auth0:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants