Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2452] returnTo should be encoded as it contains url unsafe chars #365

Merged
merged 2 commits into from
Apr 9, 2021
Merged

[SDK-2452] returnTo should be encoded as it contains url unsafe chars #365

merged 2 commits into from
Apr 9, 2021

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Apr 9, 2021 •
edited
Loading

Description

Encoding the returnTo argument as it can contain unssafe url chars (for SSR and CSR withPageAuthRequired)

References

fixes #351

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@adamjmcgrath adamjmcgrath added the review:small Small review label Apr 9, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner April 9, 2021 11:14
@vercel
Copy link

vercel bot commented Apr 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/5sKRtQG8iYCuza76ESpEAqFJefYA
✅ Preview: Canceled

[Deployment for 8382c3d canceled]

@adamjmcgrath adamjmcgrath changed the title returnTo should be encoded as it contains url unsafe chars [SDK-2452] returnTo should be encoded as it contains url unsafe chars Apr 9, 2021
stevehobbsdev
stevehobbsdev previously approved these changes Apr 9, 2021
View reviewed changes
@adamjmcgrath adamjmcgrath requested review from a team and stevehobbsdev April 9, 2021 11:18
@adamjmcgrath adamjmcgrath merged commit 85018c7 into main Apr 9, 2021
@adamjmcgrath adamjmcgrath deleted the encode-return-to branch April 9, 2021 17:03
@adamjmcgrath adamjmcgrath mentioned this pull request May 5, 2021
Merged
@adamjmcgrath adamjmcgrath mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withPageAuthRequired not redirecting to the correct url if there are multiple url params
2 participants
@adamjmcgrath @stevehobbsdev