Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setting custom cookies in withMiddlewareAuthRequired #1263

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

adamjmcgrath
Copy link
Contributor

📋 Changes

Similar fix to #1236 for merging any cookies set in custom middleware with the session cookie.

📎 References

Fixes #1253

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 23, 2023 12:50
@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextjs-auth0 ⬜️ Ignored (Inspect) Jun 26, 2023 0:06am

@adamjmcgrath adamjmcgrath added the review:small Small review label Jun 23, 2023
@adamjmcgrath adamjmcgrath changed the title Fix for settign custom cookies in withMiddlewareAuthrequired Fix for setting custom cookies in withMiddlewareAuthrequired Jun 23, 2023
@adamjmcgrath adamjmcgrath changed the title Fix for setting custom cookies in withMiddlewareAuthrequired Fix for setting custom cookies in withMiddlewareAuthRequired Jun 23, 2023
@adamjmcgrath adamjmcgrath merged commit a2d6454 into main Jun 26, 2023
3 checks passed
@adamjmcgrath adamjmcgrath deleted the fix-set-cookie-custom-mw branch June 26, 2023 14:02
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to set cookies in Vercel edge-middleware when using withMiddlewareAuthRequired()
2 participants