Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3862] Add support for JWT client authentication #1029

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Jan 24, 2023

📋 Changes

Adds support for authenticating using JWT Client Authentication.

This is supported by the clientAssertionSigningKey and clientAssertionSigningAlg config settings, which map to the AUTH0_CLIENT_ASSERTION_SIGNING_KEY and AUTH0_CLIENT_ASSERTION_SIGNING_ALG environment variables.

ef83deb also moved the jest testing setup to use jest-environment-node-single-context to fix an issue where the test for this feature would fail due to the object comparison used by openid-client due to a known issue with jest. The stateless session tests that use jest timers had a docblock added that set the environment to the builtin node environment to ensure the timers work

📎 References

SDK-3862

🎯 Testing

This fixes an issue when running tests that will provide jwks to openid-client as it does a comparison
on the constructor of the object provided which does not match as the globals are different. For tests
like the stateless session tests that need to use a jest mock like timers we can use the node
environment to ensure timers work as expected
@ewanharris ewanharris requested a review from a team as a code owner January 24, 2023 11:10
@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nextjs-auth0 ⬜️ Ignored (Inspect) Jan 24, 2023 at 11:23AM (UTC)

Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamjmcgrath adamjmcgrath merged commit 36a67b0 into main Jan 24, 2023
@adamjmcgrath adamjmcgrath deleted the feat/SDK-3862-private_key_jwt branch January 24, 2023 12:29
@adamjmcgrath adamjmcgrath mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants