Skip to content

Commit

Permalink
Merge pull request #3 from auth0/ramasilveyra-patch-1
Browse files Browse the repository at this point in the history
Add ACL public read param
  • Loading branch information
hzalaz authored Sep 22, 2017
2 parents c8235f6 + 1ada689 commit d92a357
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions aws/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ var uploader = function (version, options) {
s3Params: {
Bucket: options.bucket,
Prefix: version.remotePath,
CacheControl: version.cache
CacheControl: version.cache,
ACL: 'public-read'
}
};
var logger = options.logger;
Expand Down Expand Up @@ -60,4 +61,4 @@ var uploader = function (version, options) {

module.exports = {
uploader: uploader
};
};
3 changes: 2 additions & 1 deletion test/aws.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ describe('aws', function () {
expect(params.s3Params.Bucket).to.eql(options.bucket);
expect(params.s3Params.Prefix).to.eql('lock/1.2.3');
expect(params.s3Params.CacheControl).to.eql('max-age=0');
expect(params.s3Params.ACL).to.eql('public-read');
done();
return new events.EventEmitter();
};
Expand Down Expand Up @@ -77,4 +78,4 @@ describe('aws', function () {
emitter.emit('end');
});

});
});

0 comments on commit d92a357

Please sign in to comment.