Add __enableImpersonation flag to enable impersonation again #689
Conversation
luisrudge
changed the title
| var transactionStateMatchesState = transactionState === state; | ||
| if (!state || !transactionStateMatchesState) { | ||
| var shouldBypassStateChecking = !state && !transactionState && options.__enableImpersonation; |
There was a problem hiding this comment.
state and transactionState are missing for every impersonation call?
Also I don't know how this boolean checks works on JS but probably options. __enableImpersonation will be false 99% of the cases, so I'd move that check to the beginning of the line.
There was a problem hiding this comment.
-
state might be present if you used the advanced fields in the page:
-
var transactionState = options.state || (transaction && transaction.state) || null;
transactionState will be either provided by the developer (options.state) or empty when you're trying to impersonate
There was a problem hiding this comment.
So if the user provides a value in that field (image you shared). Where does that end up being added, options.state (transaction state) or the request state?
There was a problem hiding this comment.
the value from the screen will be inside parsedHash.state. Then it's up to the developer to call parseHash({state: 'previously-set-state'}) (this behavior wasn't altered)
| @@ -182,8 +182,11 @@ WebAuth.prototype.validateAuthenticationResponse = function(options, parsedHash, | |||
| var state = parsedHash.state; | |||
| var transaction = this.transactionManager.getStoredTransaction(state); | |||
| var transactionState = options.state || (transaction && transaction.state) || null; | |||
|
|
|||
| var transactionStateMatchesState = transactionState === state; | |||
There was a problem hiding this comment.
Won't this be true for both values of null? e.g. null === null -> transactionStateMatchesState=true?
There was a problem hiding this comment.
I think I thought about all the combinations possible and it looks fine. Might need a second pair of eyes here @cocojoe
fix #683