Adding legacy error handling for co/auth endpoint #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
suggested changes
Mar 2, 2018
| @@ -166,7 +166,9 @@ describe('auth0.WebAuth.crossOriginAuthentication', function() { | |||
| error_description: 'a huge error string' | |||
| }, | |||
| code: 'any error', | |||
There was a problem hiding this comment.
This should probably be a machine_name without spaces
| @@ -166,7 +166,9 @@ describe('auth0.WebAuth.crossOriginAuthentication', function() { | |||
| error_description: 'a huge error string' | |||
| }, | |||
| code: 'any error', | |||
| description: 'a huge error string' | |||
| description: 'a huge error string', | |||
| error: 'any error', | |||
There was a problem hiding this comment.
This should probably be a machine_name without spaces
There was a problem hiding this comment.
doesn't really matter for the tests though..
src/helper/response-handler.js
Outdated
| @@ -42,7 +42,10 @@ function wrapCallback(cb, options) { | |||
| if (err.err) { | |||
| err = err.err; | |||
| } | |||
|
|
|||
| if (options.forceLegacyError) { | |||
| errObj.error = err.error; | |||
There was a problem hiding this comment.
This means that it's possible for errObj.code !== errObj.error ... is that intended? Maybe this should fall after where err.code and errObj.description are set and set them as equal?
There was a problem hiding this comment.
makes sense. pushed a change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.