Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass to popup the needed params for auth #381

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

hzalaz
Copy link
Member

@hzalaz hzalaz commented Mar 8, 2017

Closes #378

@hzalaz hzalaz added this to the v8-Next milestone Mar 8, 2017
@hzalaz hzalaz force-pushed the fixed-email-password-popup-stuck branch from 8f2b0a3 to 5256957 Compare March 8, 2017 21:22
@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #381 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   97.61%   97.62%   +<.01%     
==========================================
  Files          35       35              
  Lines        1176     1177       +1     
  Branches      196      197       +1     
==========================================
+ Hits         1148     1149       +1     
  Misses         28       28
Impacted Files Coverage Δ
src/web-auth/popup.js 93.75% <100%> (+0.06%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5f423...2979ad2. Read the comment docs.

@hzalaz hzalaz requested a review from luisrudge March 8, 2017 21:35
@hzalaz hzalaz force-pushed the fixed-email-password-popup-stuck branch from 5256957 to 2979ad2 Compare March 9, 2017 15:03
@luisrudge luisrudge merged commit 82e5de1 into master Mar 9, 2017
@hzalaz hzalaz deleted the fixed-email-password-popup-stuck branch March 9, 2017 15:12
@hzalaz hzalaz modified the milestones: v8-Next, v8.4.0 Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants