[IAMRISK-3011] Auth0 V2 Captcha failOpen support #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkoumarianos-okta
temporarily deployed
to
external
GitHub Actions
Inactive
alexkoumarianos-okta
temporarily deployed
to
external
GitHub Actions
Inactive
alexkoumarianos-okta
temporarily deployed
to
external
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
srijonsaha
requested changes
Dec 21, 2023
src/web-auth/captcha.js
Outdated
| @@ -189,6 +189,23 @@ function injectCaptchaScript(element, opts, callback, setValue) { | |||
| window.arkose = arkose; | |||
| callback(arkose); | |||
| }; | |||
| } else if (opts.provider === AUTH0_V2_CAPTCHA_PROVIDER) { | |||
| var a0RetryCount = 0; | |||
There was a problem hiding this comment.
We shouldn't have a separate variable for Auth0 V2, we can use the retryCount variable since when this script runs there will always be one provider so the counter will only represent the retries for that provider.
src/web-auth/captcha.js
Outdated
| @@ -189,6 +189,23 @@ function injectCaptchaScript(element, opts, callback, setValue) { | |||
| window.arkose = arkose; | |||
| callback(arkose); | |||
| }; | |||
| } else if (opts.provider === AUTH0_V2_CAPTCHA_PROVIDER) { | |||
| var a0RetryCount = 0; | |||
| attributes['error-callback'] = function () { | |||
There was a problem hiding this comment.
I don't think this is correct. Are you trying to retry the script loading? That should be done through the attribute 'onerror' like Arkose example above. Also let's try to combine the code since it's identical to Arkose.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLScriptElement#examples
src/web-auth/captcha.js
Outdated
| if (a0RetryCount < MAX_RETRY) { | ||
| setValue(); | ||
| globalForCaptchaProvider(challenge.provider).reset(widgetId); | ||
| a0RetryCount++; |
There was a problem hiding this comment.
Let's try to use the retryCount variable.
src/web-auth/captcha.js
Outdated
| globalForCaptchaProvider(challenge.provider).reset(widgetId); | ||
| a0RetryCount++; | ||
| } else { | ||
| // similar implementation to ARKOSE_PROVIDER failOpen |
There was a problem hiding this comment.
nit: no need for comment, let's remove
alexkoumarianos-okta
temporarily deployed
to
external
GitHub Actions
Inactive
frederikprijck
approved these changes
Jan 4, 2024
frederikprijck
temporarily deployed
to
external
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
external
GitHub Actions
Inactive
frederikprijck
temporarily deployed
to
external
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made changes to allow auth0_v2 to handle failOpen by passing a distinct dummy token.
References
https://auth0team.atlassian.net/browse/IAMRISK-3011