fix: e2e tests crashing #1254
fix: e2e tests crashing #1254
Conversation
the dependency overrides *should* already be using ^0.6.0 as the minimum version since it is a transitive dependency of our override of dartssh2... but that would be asking too much of the toolchain.
|
Tested locally and the Dart tests are passing now, the C tests are flaking which is causing a timeout long enough for GNU parallel to exit with a timeout. |
XavierChanth
force-pushed
the
xc-fix-dartssh2
branch
from
9ab061f
to
47cb921
Compare
| @@ -42,12 +42,15 @@ if [ $allowParallelization == "true" ] && command -v env_parallel >/dev/null 2>& | |||
| export -f run_tests_for_daemon | |||
| # Run a round of tests against each daemon in parallel | |||
| parallel --jobs 5 \ | |||
| --timeout 3m \ | |||
There was a problem hiding this comment.
This ends up being 3minutes per daemon - which may be a bit short, we will have to see.
| @@ -30,6 +30,7 @@ dependency_overrides: | |||
| git: | |||
| url: https://github.com/atsign-foundation/dartssh2 | |||
| ref: trunk | |||
There was a problem hiding this comment.
Do we need to make a transitive dependency explicit like this? My take is that we just need to bump the lock file(s)
|
After some discussion with @gkc I've backed out the changes to We should probably evaluate a mechanism to ensure that |
|
@XavierChanth please merge if you're happy with the revised approach (or we can discuss in arch). |
|
FYI @gkc @cpswan @JeremyTubongbanua , beyond these changes, the e2e tests were failing because I found some non-utf8 characters in the .ssh/authorized_keys file on the test run - The Dart daemon calls |
the dependency overrides should already be using ^0.6.0 as the minimum version since it is a transitive dependency of our override of dartssh2... but that would be asking too much of the toolchain.
- What I did
- How I did it
- How to verify it
- Description for the changelog
fix: e2e tests crashing