Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for child process exits periodically #1210

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

XavierChanth
Copy link
Member

fixes #1193

- What I did

  • Created a dynamic array to track process ids for child processes created during the lifecycle of the program
  • In between each monitor message read, check if each child process has exited (with waitpid) and remove it from the queue
  • This solution assumes that 99% of the time there will be only 0 or 1 child process
    • 1% or less there will ever be 2 or more.

- How I did it

- How to verify it

- Description for the changelog
fix: check for child process exits periodically

@XavierChanth XavierChanth marked this pull request as draft July 22, 2024 19:03
@XavierChanth
Copy link
Member Author

@cconstab can you test that this fixes your issues in #1193 please

@XavierChanth XavierChanth marked this pull request as ready for review July 22, 2024 19:32
@JeremyTubongbanua
Copy link
Member

Quickly read over the code and LGTM

@XavierChanth XavierChanth merged commit 856d19b into trunk Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpha C sshnpd does not exit cleanly
2 participants