-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (c sshnpd) allocate threaded memory outside of the thread #1171
Conversation
…y from fork'd thread)
running into a 16 KB leak after establishing SSH connection, converting to draft while I investigate |
After establishing an SSH session with 2 fresh atSigns, we get 16KB lost. Threaded leak summary
Main process leak summary
Full valgrind logs: https://gist.github.com/JeremyTubongbanua/a49a783ea400506d871239873224d1a8 |
The reason for this leak is at_c related. See atsign-foundation/at_c#328 for an upcoming fix. Next commit will most likely be a commit hash change for atsdk so that the C Daemon will use the latest trunk hash for the memory leak fix. |
- What I did
- How to verify it
new leak summary (after closing thread)
notice that the 585 bytes that were usually suppressed are no longer lost.
- Description for the changelog
fix: no longer lose 585B every time SSH session is established