Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add "sharedKeyEnc" to the metadata to propagate from server to client on receiving end #2043

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented Jul 29, 2024

Resolves #1364

- What I did

  • When running no-ports locally, an issue appear where the client waits for the srvd response and eventually times out. This occurs because the client receives the notification sent by srvd but fails to decrypt the message. The decryption fails because the "sharedEncryptedKey" received from the sender to the receiver is not being propagated from the receiver's server to the receiver's client via the notification.

Adding the log snippet:

SEVERE|2024-07-29 11:34:42.853820|NotificationServiceImpl (@alice🛠)|Failed to fetchData caused by
key not found : Exception: @alice🛠:shared_key@sitaram🛠 does not exist in keystore 

INFO|2024-07-29 11:34:44.149909| SrvdChannel |Still waiting for srvd response 
INFO|2024-07-29 11:49:03.865867| SrvdChannel |Still waiting for srvd response 
WARNING|2024-07-29 11:49:04.976872| SrvdChannel |Timed out waiting for srvd response 

Error : TimeoutException: Connection timeout to srvd @sitaram🛠 service

- How I did it

  • Add "sharedEncKey" to the metadata in MonitorVerbHandler.dart

- How to verify it

  • After the changes, tested no-ports manually and able to run successfully. Adding the log file.
    client-no-ports.log

- Description for the changelog

  • In MonitorVerbHandler, add "sharedKeyEnc" to the metadata to propagate the sharedEncryptedKey in
    notifications from the server to the client.

There is a follow-up PR in at_client.

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that there was an old ticket for this - #1364

@gkc gkc merged commit 4f2270b into trunk Jul 29, 2024
26 checks passed
@gkc gkc deleted the add_sharedKeyEnc_to_metadata branch July 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"inline" encrypted symmetric key not being sent to client monitor
2 participants