-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enforce superset access check for approving apps #2023
feat: Enforce superset access check for approving apps #2023
Conversation
@sitaram-kalluri - can you add tests for these scenarios please:
|
One more scenario
|
…check-for-approving-apps
…check-for-approving-apps
@sitaram-kalluri LGTM; please can you run the NoPorts e2e tests locally against this at_server branch just to verify that everything is OK? To run NoPorts e2e tests locally:
In a NoPorts repo clone
|
Ran NoPorts tests locally and all tests passed. Attaching the log snippet.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
- How I did it
- How to verify it
- Description for the changelog