-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hive max length bug #1878
fix: Hive max length bug #1878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we restrict the length to 248 if it doesn't start with "cached:"? Leaves enough for a "cached:"prefix to be added on a caching atServer / client
sure Gary. |
@gkc I had a discussion with @sitaram-kalluri on this. |
Yes I believe so |
..id = '123') | ||
.build(); | ||
var key = | ||
'iujpsefqvdzmtqthrqbaxqszxokaiutvpnbcphcjvjghpdxzdwywfsaowruwafmcudeoarfhuncezjkwbdvprcbujeptisxkjtztxogqqrrnjpqrdsjmcrpmpusrkzaksdfleyzsuarjhsqvxwicxulzqjzcwwjaupxzoqfwenkfonwhxtmwamiyzqqoesnreknrzwxazvykbybafrlwgqsyreudprnakoioqiwoqiwqdebbdwbdywebwydbwrr@alice'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For readability, instead of long string of letters unclear as to what length they are, can we instead create and use a function which returns a random string of whatever length is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
fixes: #1863
- What I did
- How I did it
- How to verify it
fix: test persistence for hive max key length check at_client_sdk#1281
fix: test persistence for hive key length check #1877
With this fix, server will return data:null when updating key with length > 255 chars. Have to make fix in server to return correct error message.