test:added tests for config changes #1157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkc
previously approved these changes
Mar 16, 2023
…st/commons.dart to functional_test/test/functional_test_commons.dart; '
|
Hey @purnimavenkatasubbu - there are timing issues in the tests you added. I'll think over the weekend about how to resolve these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added tests for stats:13(Access log compaction), stats:14 (Commit log compaction)
- How I did it
By setting the compaction job to run every 1 minute by using the config: set verb and then updating the keys multiple times.
- How to verify it
acesslog_compaction_test.dart and commitlog_compaction_test.dart should pass.
- Description for the changelog