This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Remove Linux Electron arm64 prebuild (temporary) #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
changed the title
|
@dennisameling We have currently pushed a workaround in VS Code to always rebuild keytar. |
|
As the VS Code team has a workaround, let's close this one in favor of #352 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be used as a temporary fix for #347 until I have resolved the issues with Travis. This repo is still using travis-ci.org which makes it very impractical to be testing my fixes, as it takes 1+ hour to kick off the builds. I wanted to test in my own fork but somehow have a negative credit balance on travis-ci.com despite having ran 0 tests in the last 2 months 😅
If #347 is time-critical then you could merge this PR for the time being, otherwise I expect to have #349 sorted out within the coming day or two, as soon as Travis support gets back to me.