This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Visualize aborted keybindings #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Do not merge until atom/atom-keymap#227 is merged into Atom.
Adds a new
abortedtype to the resolver display with the stop octicon so people can see when a keybinding has been selected because others have been aborted before it. This is in addition to theused,unusedandunmatchedtypes already present.Alternate Designs
None considered.
Benefits
Gives people more information on why a key binding is selected.
Possible Drawbacks
There is confusion around an aborted keybinding which allows other keybindings to be found and the
abort!command which does not. This does nothing to alleviate this confusion.Applicable Issues